Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prop value is symbol and invalid type throw error in dev #7809

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prop value is symbol and invalid type throw error in dev #7809

wants to merge 1 commit into from

Conversation

virgosoy
Copy link

@virgosoy virgosoy commented Mar 1, 2023 •
edited by edison1105
Loading

@haoqunjiang

This comment was marked as resolved.

Sign in to view
@haoqunjiang haoqunjiang closed this Jun 5, 2024
@skirtles-code
Copy link
Contributor

@sodatea I think this should be reopened, I believe you misunderstood the author's intent.

The type mismatch on the prop was intentional. The problem being fixed here is that the warning message isn't generated correctly.

@haoqunjiang
Copy link
Member

Oops. Sorry. Reopened.

@haoqunjiang haoqunjiang reopened this Jun 5, 2024
@skirtles-code
Copy link
Contributor

#8539 seems to be a similar idea.

@skirtles-code skirtles-code mentioned this pull request Jun 23, 2024
Open
@edison1105 edison1105 added the duplicate This issue or pull request already exists label Aug 27, 2024
@edison1105
Copy link
Member

Duplicate of #8539

@edison1105 edison1105 marked this as a duplicate of #8539 Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
Issue / PR Management
Status: Needs Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(runtime-core): Runtime error when mistakenly converting symbols to a string during props validation
4 participants
@virgosoy @haoqunjiang @skirtles-code @edison1105