-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(runtime-core): Fix cssVar cannot work in teleport #7364
base: main
Are you sure you want to change the base?
Conversation
Could you maybe explain how your proposed solution compares to the existing PRs for those two issues? |
|
@sxzz can you help me to review. |
@tinyfind can you provide answers for skirtles questions please?
|
;(vnode.children as VNode[]).forEach(c => | ||
setVarsOnVNode(c, vars, createObserve) | ||
) | ||
createObserve(vnode.target as Node) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the correct fix. The target
of Teleport
is often the body
, and if we observe the body
, the cost will be enormous. Therefore, this solution is not reasonable.
close: #7312
close: #7342