Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sfc-playground): style improvements #6000

Merged
merged 1 commit into from
May 24, 2022

Conversation

phanan
Copy link
Member

@phanan phanan commented May 24, 2022

This PR adds some (hopefully) improvements to the current style of the playground, namely:

  • Standardize the buttons to use flexbox instead of middle-aligning and/or line-height for vertical/horizontal centering
  • Update the SVGs to use currentColor instead of arbitrary color values, allowing controlling their colors from CSS, which in turn allows hover effects
  • Make prod/dev env badge more prominent
  • Some minor improvements/fixes for CSS rules and variables

Before

image
image

After

image
image

@phanan phanan requested a review from yyx990803 May 24, 2022 18:30
@yyx990803 yyx990803 merged commit 109751a into vuejs:main May 24, 2022
@phanan phanan deleted the chore/sfc-impr branch May 24, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants