-
-
Notifications
You must be signed in to change notification settings - Fork 9.2k
feat(runtime-core): add 'debug' composition api #5383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bichikim
wants to merge
8
commits into
vuejs:main
Choose a base branch
from
bichikim:debug-composition
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+96
−0
Open
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d9ba1a9
feat(runtime-core): add 'debug' composition api
bichikim e82c76d
fix: add the debug in index.ts file
bichikim 848b9d9
fix: debug comment
bichikim c7b600a
fix: for function size
bichikim dac1767
add debug testing
bichikim 190e76c
add a test case for calling the debug function multiple times
bichikim 8c6a92d
Merge branch 'main' into debug-composition
edison1105 a577158
[autofix.ci] apply automated fixes
autofix-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import {debug} from '../src/debug' | ||
| import { | ||
| h, | ||
| render, | ||
| defineComponent, | ||
| ref, getCurrentInstance, ComponentInternalInstance, nodeOps, | ||
| serializeInner as inner | ||
| } from '@vue/runtime-test' | ||
|
|
||
| describe('debug', () => { | ||
| test('watching states', () => { | ||
| const root = nodeOps.createElement('div') | ||
| let instance: ComponentInternalInstance | ||
| const Comp = defineComponent({ | ||
| setup() { | ||
| const name = ref('foo') | ||
| debug({ | ||
| name, | ||
| }) | ||
| return () => ( | ||
| h('div', name.value) | ||
| ) | ||
| }, | ||
| mounted() { | ||
| instance = getCurrentInstance()! | ||
| }, | ||
| }) | ||
| render(h(Comp), root) | ||
| expect(inner(root)).toBe('<div>foo</div>') | ||
| expect(instance!.setupState).toEqual({ | ||
| name: 'foo', | ||
| }) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import {reactive} from '@vue/reactivity' | ||
| import {getCurrentInstance} from './component' | ||
|
|
||
| /** | ||
| * this debug function is a helper for watching states in the vue devtool (it runs only in dev mode) | ||
| * @example | ||
| * const Component = defineComponent({ | ||
| * setup() { | ||
| * const name = ref('foo') | ||
| * debug({ | ||
| * // watch states in the vue devtool | ||
| * name, | ||
| * }) | ||
| * return h('div', name.value) | ||
| * }, | ||
| * }) | ||
| * @param states any states you want to see in the vue devtool | ||
| */ | ||
| export const debug = __DEV__ ? (states: Record<string, any>) => { | ||
| const instance = getCurrentInstance() | ||
| if (instance) { | ||
| instance.setupState = reactive(Object.assign({}, states, instance.setupState)) | ||
| } | ||
| } : (states: Record<string, any>) => { | ||
| // empty | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.