Skip to content

Update codegen.ts #5124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zhangenming wants to merge 2 commits into from
Closed

Update codegen.ts #5124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b46b0e4
Update codegen.ts
zhangenming Dec 16, 2021
89613a1
Update transformText.ts
zhangenming Dec 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/compiler-core/src/codegen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ export function generate(
} = {}
): CodegenResult {
const context = createCodegenContext(ast, options)
if (options.onContextCreated) options.onContextCreated(context)
options.onContextCreated?.(context)
Copy link
Member

@edison1105 edison1105 Dec 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #4882

const {
mode,
push,
Expand Down
8 changes: 4 additions & 4 deletions packages/compiler-core/src/transforms/transformText.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ export const transformText: NodeTransform = (node, context) => {
) {
// perform the transform on node exit so that all expressions have already
// been processed.
const children = node.children
let currentContainer: CompoundExpressionNode | undefined = undefined
let hasText = false

return () => {
const children = node.children
let currentContainer: CompoundExpressionNode | undefined = undefined
let hasText = false

for (let i = 0; i < children.length; i++) {
const child = children[i]
if (isText(child)) {
Expand Down