Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-sfc): should judgment if not children #464

Merged
merged 2 commits into from
Nov 19, 2019
Merged

fix(compiler-sfc): should judgment if not children #464

merged 2 commits into from
Nov 19, 2019

Conversation

underfin
Copy link
Member

No description provided.

yyx990803
yyx990803 requested changes Nov 16, 2019
View reviewed changes
Copy link
Member

@yyx990803 yyx990803 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if a block doesn't contain any content we should just ignore it (return early here if !children.length)

@underfin
Copy link
Member Author

I see.

@yyx990803 yyx990803 merged commit 1efb35e into vuejs:master Nov 19, 2019
@underfin underfin deleted the fix-sfc branch November 19, 2019 14:11
@vue-bot
Copy link
Contributor

vue-bot commented Nov 19, 2019

Hey @underfin, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@meteorlxy meteorlxy mentioned this pull request Oct 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 yyx990803 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@underfin @vue-bot @yyx990803