Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-dom): v-bind work with HTML tag #3002

Closed
wants to merge 7 commits into from
Closed

fix(compiler-dom): v-bind work with HTML tag #3002

wants to merge 7 commits into from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Jan 14, 2021 •
edited
Loading

close #3001

@edison1105 edison1105 changed the title fix(compiler-dom): " in v-bind in HTML strips HTML tag fix(compiler-dom): v-bind work with HTML tag Jan 14, 2021
@skirtles-code skirtles-code mentioned this pull request Jan 20, 2021
Closed
@edison1105 edison1105 marked this pull request as draft March 28, 2021 10:03
@edison1105 edison1105 marked this pull request as ready for review March 28, 2021 13:45
@edison1105 edison1105 marked this pull request as draft March 29, 2021 01:12
@edison1105 edison1105 marked this pull request as ready for review March 29, 2021 02:46
@HcySunYang HcySunYang added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label Mar 29, 2021
skirtles-code
skirtles-code suggested changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@skirtles-code skirtles-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some suggestions. Hope they're helpful.

packages/compiler-dom/src/decodeHtmlBrowser.ts Outdated Show resolved Hide resolved
packages/compiler-dom/__tests__/index.spec.ts Outdated Show resolved Hide resolved
@yyx990803
Copy link
Member

Thanks for the PR - the root cause is that the browser decoder is not properly differentiating HTML strings vs. attribute values. See 6690372 (used tests from this PR)

@yyx990803 yyx990803 closed this May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirtles-code skirtles-code skirtles-code requested changes

Assignees
No one assigned
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using " in v-bind in HTML strips HTML tag
4 participants
@edison1105 @yyx990803 @skirtles-code @HcySunYang