Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): add if #1906

Closed
wants to merge 1 commit into from
Closed

fix(runtime-core): add if #1906

wants to merge 1 commit into from

Conversation

ivanheral
Copy link

Hi.
I have problems with the generated html using vue 3 and jsx.

some html tags are not painted correctly.

Can you add the code of @ConradSollitt?

vuejs/jsx-vue2#141

Thanks.

@ivanheral ivanheral changed the title add if fix(runtime-core): add if Aug 20, 2020
@yyx990803
Copy link
Member

This is the wrong fix. h only accepts 3 arguments. JSX implementations should generate code using createVNode.

@yyx990803 yyx990803 closed this Aug 20, 2020
@ivanheral
Copy link
Author

ivanheral commented Aug 20, 2020

Hi @yyx990803,

accepts more than 3 arguments when add Fragment.

I have an example using vue3 with htm with the problem.

@ivanheral
Copy link
Author

@yyx990803,
Here you have a link with the example of the problem. I have to replace rc6 with the fix to see html correctly.
https://github.com/ivanheral/vue3_fix

@ivanheral ivanheral deleted the fix_h branch August 21, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants