Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(runtime-core): handling PropType<Function> #1896

Merged
merged 3 commits into from
Aug 19, 2020
Merged

types(runtime-core): handling PropType<Function> #1896

merged 3 commits into from
Aug 19, 2020

Conversation

pikax
Copy link
Member

@pikax pikax commented Aug 19, 2020

fix #1891

Honestly don't know why adding | {} works here 🤔

@HcySunYang HcySunYang mentioned this pull request Aug 19, 2020
Closed
@yyx990803
Copy link
Member

This looks to make slightly more sense than #1898 but honestly both are kinda magic 😅

@yyx990803 yyx990803 merged commit c2913d5 into vuejs:master Aug 19, 2020
@pikax pikax deleted the types/correct_type_for_function_prop branch August 15, 2021 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

defineComponent infers props incorrectly when prop is Function type
2 participants
@pikax @yyx990803