Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/proxy performance #1247

Closed
wants to merge 8 commits into from
Closed

Feat/proxy performance #1247

wants to merge 8 commits into from

Commits on May 27, 2020

  1. feat(PublicInstanceProxyHandlers): improve performance by creating sc… 

    …oped functions that return values faster

It's much faster when repeatedly accessing variables, but we still need to investigate the memory implications when having a large number of component instances
    @basvanmeurs
    basvanmeurs committed May 27, 2020
    Configuration menu
    Copy the full SHA
    23c3a19 View commit details
    Browse the repository at this point in the history

  2. fix(componentProxy): found some issues running unit tests

    @basvanmeurs
    basvanmeurs committed May 27, 2020
    Configuration menu
    Copy the full SHA
    56210b6 View commit details
    Browse the repository at this point in the history

  3. feat(componentProxy): improve typing

    @basvanmeurs
    basvanmeurs committed May 27, 2020
    Configuration menu
    Copy the full SHA
    0ce64c7 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2020

  1. chore(componentProxy): remove console.log

    @basvanmeurs
    basvanmeurs committed May 28, 2020
    Configuration menu
    Copy the full SHA
    ea2f015 View commit details
    Browse the repository at this point in the history

  2. feat(componentProxy): do not store a scoped PropGetterFactory per com… 

    …ponent instance

Because it does not impact proxy get performance and it does decrease memory consumption and improve instance creation performance.
    @basvanmeurs
    basvanmeurs committed May 28, 2020
    Configuration menu
    Copy the full SHA
    8b31ee9 View commit details
    Browse the repository at this point in the history

  3. feat(componentProxy): do not create new functions for every instance,… 

    … rather reuse them per component type

Reusing ensures that memory usage is limited, while only slightly impacting performance.
    @basvanmeurs
    basvanmeurs committed May 28, 2020
    Configuration menu
    Copy the full SHA
    0b7d473 View commit details
    Browse the repository at this point in the history

  4. refactor(componentProxy): improve structure and move getPropGetter to… 

    … global scope
    @basvanmeurs
    basvanmeurs committed May 28, 2020
    Configuration menu
    Copy the full SHA
    d232d2e View commit details
    Browse the repository at this point in the history

  5. refactor(componentProxy): add comment why a new get/has proxy handler… 

    … is created for every component instance
    @basvanmeurs
    basvanmeurs committed May 28, 2020
    Configuration menu
    Copy the full SHA
    facda62 View commit details
    Browse the repository at this point in the history