Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inherited class binding on components inside transition-group is not updated #677

Closed
jonaskuske opened this issue Jan 30, 2020 · 4 comments

Comments

@jonaskuske
Copy link
Contributor

jonaskuske commented Jan 30, 2020

Version

3.0.0-alpha.4

Reproduction link

https://codepen.io/21stCenturyJonas/pen/ZEYdOBg?editors=1010

Steps to reproduce

  1. Render list of components inside <transiton-group> using v-for
  2. Add class binding that relies on index to component
  3. Update the list so indices change

What is expected?

The class binding updates as the rendered list changes.
If the class binding evaluated index === 0 and the index is not 0 anymore, the binding should evaluate to false and the class should be removed.

What is actually happening?

The class is not removed, even though the expression in the class binding now evaluates to false.

@dsfx3d
Copy link

dsfx3d commented Feb 8, 2020

Is this issue open for PRs?

@jonaskuske
Copy link
Contributor Author

Well I don't have the time to work on this myself at the moment, and since there's been no activity from others, I'd assume so?

Prior triage would be appreciated though @yyx990803 :)

@jonaskuske
Copy link
Contributor Author

@yyx990803 There's a regression in the latest alpha, the repro from above (https://codepen.io/21stCenturyJonas/pen/ZEYdOBg, updated it to use alpha.12) is failing again.
It works when going back to alpha.11.

@yyx990803
Copy link
Member

This is fixed in a6e2b10

@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants