You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Call Set::add or Map::set.
Those methods are specified to return the collection itself, so they can be chained: set.add(1).add(2).add(3).
What is expected?
Those methods should return the reactive collection so that set.add(1) === set is true and reactivity works when chaining.
What is actually happening?
Those methods return the raw collection, breaking the collections contracts and breaking reactivity.
I pointed a few other things that are less clear-cut bugs but probably not desirable behaviors (e.g. observable differences between reactive and non-reactive collections behaviors) here: 50adc01
The text was updated successfully, but these errors were encountered:
Concerning your comments about the other details, I'd suggest to open a new issue (or several). The commits you commented on are a couple months old now, we might need a central place to discuss them.
Version
3.0.2
Reproduction link
https://jsfiddle.net/v9k3jmog/
Steps to reproduce
Call Set::add or Map::set.
Those methods are specified to return the collection itself, so they can be chained:
set.add(1).add(2).add(3)
.What is expected?
Those methods should return the reactive collection so that
set.add(1) === set
is true and reactivity works when chaining.What is actually happening?
Those methods return the raw collection, breaking the collections contracts and breaking reactivity.
I pointed a few other things that are less clear-cut bugs but probably not desirable behaviors (e.g. observable differences between reactive and non-reactive collections behaviors) here:
50adc01
The text was updated successfully, but these errors were encountered: