Skip to content

Commit

Permalink
docs(type): remove unmount parameters (#2601)
Browse files Browse the repository at this point in the history
  • Loading branch information
privatenumber committed Feb 3, 2021
1 parent 60e05ef commit 18b0c9a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions packages/runtime-core/__tests__/apiCreateApp.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,12 @@ describe('api: createApp', () => {
const app = createApp(Comp)

// warning
app.unmount(root)
app.unmount()
expect(`that is not mounted`).toHaveBeenWarned()

app.mount(root)

app.unmount(root)
app.unmount()
expect(serializeInner(root)).toBe(``)
})

Expand Down
2 changes: 1 addition & 1 deletion packages/runtime-core/src/apiCreateApp.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export interface App<HostElement = any> {
rootContainer: HostElement | string,
isHydrate?: boolean
): ComponentPublicInstance
unmount(rootContainer: HostElement | string): void
unmount(): void
provide<T>(key: InjectionKey<T> | string, value: T): this

// internal, but we need to expose these for the server-renderer and devtools
Expand Down

0 comments on commit 18b0c9a

Please sign in to comment.