Skip to content

Conversation

@aladdin-add
Copy link
Contributor

No description provided.

@nickmessing
Copy link

IMO it's better to add #!/bin/sh to test.sh, chmod +x it and then add ./test.sh as a script because it's sh compatible and there is no need for bash per se.

@nickmessing
Copy link

Just as option, maybe it's worth considering replacing sh with shelljs just like vue?

@aladdin-add
Copy link
Contributor Author

@nickmessing up to this. I encountered some questions when running test on windows 10. #748 (comment)

@nickmessing
Copy link

@aladdin-add, that is fixed by using shelljs which is cross-platform

@LinusBorg
Copy link
Contributor

@nickmessing is this good to merge for you?

@nickmessing
Copy link

@LinusBorg, yes, I use only linux based operating systems but this solution will not work on windows. As long as nobody who works on this template uses windows it's fine but if there is requirement to support windows I'd highly recommend rewriting test.sh in .js with shelljs.

So it's your call, do you want to support windows or unix is okay? 😉

@aladdin-add
Copy link
Contributor Author

aladdin-add commented Sep 3, 2017

ready to merge. 🚀
👍 to replace sh to shelljs, we can finish it in another PR. (I created a new issue #895)

@LinusBorg
Copy link
Contributor

Leave have a look at #1218. I took a bit more ambitious approach to improve the testing story for the template.

@aladdin-add aladdin-add deleted the patch-1 branch April 24, 2018 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants