-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Issue #1226: Add easy-deploy option when installing the template using Vue CLI #1230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
We generally have some issues with CI tests, which is why I submitted #1218. But you submitted 2 versions of this PR, can the old one be closed? |
| "postcss-loader": "^2.0.8", | ||
| "postcss-url": "^7.2.1", | ||
| {{#deploy}} | ||
| "push-dir": "^0.4.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a package that makes this even easier imho: gh-pages
Have you considered it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did consider the gh-pages package, but when checking out both of the packages documentation, gh-pages just seems to make it more complicated than it should be.
With the push-dir package, any flags can simply be added to the package.json file, such as --allow-unclean and --force, if required by the end-user.
|
Yeah, I did leave a comment on the old PR with regards to closing it for me please. |
|
Closed it.. by you can close your own PRs yourself I think ;) |
|
I did try to close, but I couldn't for the life of me find how to do it. It was probably right in front of me :) |
…g Vue CLI * Add `deployBuild` prompt in `meta.js` * Add `if` conditional around `npm run build;` in templates `package.json`
…g Vue CLI * Add 'when' conditional to `deployBuild` prompt in `meta.js`
Add an option to the template installer that allows the user to add easy-deployment for GitHub pages.
If the user opts-in to this option, they will then be presented with 2 further prompts for:
Once these details are entered, the will then simply have to run npm run deploy to deploy a built site to the correct branch of the repository.