Skip to content

Conversation

@codetheorist
Copy link

@codetheorist codetheorist commented Jan 6, 2018

Add an option to the template installer that allows the user to add easy-deployment for GitHub pages.

If the user opts-in to this option, they will then be presented with 2 further prompts for:

  • Branch Name
  • Base URL (for project pages)

Once these details are entered, the will then simply have to run npm run deploy to deploy a built site to the correct branch of the repository.

@codetheorist
Copy link
Author

The tests failed on this however further investigation revealed issues with a previously merged commit.

A working demo built using this Webpack template is available on GitHub here.

The actual template that is generated is also available on the master branch for the repo here.

@LinusBorg
Copy link
Contributor

We generally have some issues with CI tests, which is why I submitted #1218.

But you submitted 2 versions of this PR, can the old one be closed?

"postcss-loader": "^2.0.8",
"postcss-url": "^7.2.1",
{{#deploy}}
"push-dir": "^0.4.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a package that makes this even easier imho: gh-pages

Have you considered it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did consider the gh-pages package, but when checking out both of the packages documentation, gh-pages just seems to make it more complicated than it should be.

With the push-dir package, any flags can simply be added to the package.json file, such as --allow-unclean and --force, if required by the end-user.

@codetheorist
Copy link
Author

Yeah, I did leave a comment on the old PR with regards to closing it for me please.

@LinusBorg
Copy link
Contributor

Closed it.. by you can close your own PRs yourself I think ;)

@codetheorist
Copy link
Author

I did try to close, but I couldn't for the life of me find how to do it. It was probably right in front of me :)

…g Vue CLI

* Add `deployBuild` prompt in `meta.js`
* Add `if` conditional around `npm run build;` in templates `package.json`
…g Vue CLI

* Add 'when' conditional to `deployBuild` prompt in `meta.js`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants