airbnb eslint config compatibility with vuex #1003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusBorg
suggested changes
Dec 2, 2017
| }], | ||
| // disallow reassignment of function parameters | ||
| // disallow parameter object manipulation except for specific exclusions | ||
| 'no-param-reassign': ['error', { |
Contributor
There was a problem hiding this comment.
This would have to be wrapped in a handlebars conditional {{#if_eq lintConfig 'airbnb'}}
Contributor
Author
There was a problem hiding this comment.
It already is. Check line 41.
Contributor
There was a problem hiding this comment.
Oh. Sometimes I'm stupid :)
Contributor
There was a problem hiding this comment.
I'll merge this and then remove some of the node-spcific exceptions, because this is a frontend-template, and you are likely not gonna write express routes in it - that would be something for a SSR-focussed template.
LinusBorg
approved these changes
Dec 4, 2017
Contributor
|
(close/reopen to trigger CI) |
LinusBorg
added a commit
that referenced
this pull request
Dec 11, 2017
* develop: remove unnecessary exceptions bump version to 1.2.6 Add JX support (close #1146) Automatically install Dependencies and fix lint errors (#1133) Set `allChunks: true` by default (close #1110) (#1149) airbnb eslint config compatibility with vuex (#1003) Document babel target env configuration (#1144) Revert "remove uneccessary target.browsers (#1004)" (#1083) fix filename of `.eslintignore` (#1136) webpack.conf.js is not needed in jest and e2e (#1135) # Conflicts: # template/test/e2e/custom-assertions/elementCount.js
frandiox
pushed a commit
to OnsenUI/vue-cordova-webpack
that referenced
this pull request
Dec 25, 2017
shenron
pushed a commit
to shenron/webpack
that referenced
this pull request
Mar 20, 2018
shenron
pushed a commit
to shenron/webpack
that referenced
this pull request
Mar 20, 2018
* develop: remove unnecessary exceptions bump version to 1.2.6 Add JX support (close vuejs-templates#1146) Automatically install Dependencies and fix lint errors (vuejs-templates#1133) Set `allChunks: true` by default (close vuejs-templates#1110) (vuejs-templates#1149) airbnb eslint config compatibility with vuex (vuejs-templates#1003) Document babel target env configuration (vuejs-templates#1144) Revert "remove uneccessary target.browsers (vuejs-templates#1004)" (vuejs-templates#1083) fix filename of `.eslintignore` (vuejs-templates#1136) webpack.conf.js is not needed in jest and e2e (vuejs-templates#1135) # Conflicts: # template/test/e2e/custom-assertions/elementCount.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added override to
no-param-reassignrule to make airbnb eslint config compatible with vuexFixes #883