Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guide > Tooling > Single File Components の翻訳を追従 #309

Merged
merged 8 commits into from
May 6, 2021
Merged

Guide > Tooling > Single File Components の翻訳を追従 #309

merged 8 commits into from
May 6, 2021

Conversation

naokie
Copy link
Member

@naokie naokie commented May 4, 2021

@netlify
Copy link

netlify bot commented May 4, 2021 •
edited
Loading

Deploy preview for vuejs-v3-ja-doc-preview ready!

Built with commit 26ab4e3

https://deploy-preview-309--vuejs-v3-ja-doc-preview.netlify.app

@naokie naokie mentioned this pull request May 4, 2021
Closed
60 tasks
kazupon
kazupon requested changes May 5, 2021
View reviewed changes
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューしました。確認お願いします！

src/guide/single-file-component.md Outdated Show resolved Hide resolved
@naokie
Copy link
Member Author

naokie commented May 6, 2021

Suggestion ありがとうございました。
訳しながら、どうしようか迷っていたポイントをピンポイントで指摘されちゃいましたね 😅

@naokie naokie requested a review from kazupon May 6, 2021 11:20
@kazupon kazupon merged commit 3883d72 into vuejs-jp:lang-ja May 6, 2021
@naokie naokie deleted the guide/single-file-component branch May 8, 2021 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon approved these changes

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naokie @kazupon