Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing character creation outputs to chat #424

Closed
1 task done
metodi022 opened this issue May 10, 2023 · 1 comment
Closed
1 task done

Closing character creation outputs to chat #424

metodi022 opened this issue May 10, 2023 · 1 comment
Assignees
@anthonyronda
Labels
bug Something isn't working chat Templating or logic inside a chat card good first issue Good for newcomers

Comments

@metodi022
Copy link

metodi022 commented May 10, 2023 •
edited
Loading

What happened?

  1. Open the character creation for an actor
  2. Close it immediately
  3. Observe in the chat there will be a message with empty stats

image

What is the expected behaviour?

If you close the character creation window of an actor, there should be no output in chat.

Relevant Errors and Warnings

There are no error messages.

Additional Support Details

Foundry Virtual Tabletop: Version 10, 10.291
Game System: ose, 1.8.4
Active Modules: 16
Performance Mode: 2

OS: Windows NT 10.0; Win64; x64
Client: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/112.0

Foundry VTT Core Version

V10

Old-School Essentials Core Version

1.8.4

Please update your browser regularly. Which (updated) browsers are you seeing the problem on?

Firefox

Code of Conduct

  • I agree to follow this project's Code of Conduct
@metodi022 metodi022 added bug Something isn't working triage This bug still needs to be validated and weighted labels May 10, 2023
@anthonyronda anthonyronda added good first issue Good for newcomers chat Templating or logic inside a chat card and removed triage This bug still needs to be validated and weighted labels May 25, 2023
@Stew-rt Stew-rt mentioned this issue May 27, 2023
Open
@Stew-rt
Copy link
Contributor

Stew-rt commented May 29, 2023

Individual roll cards (str, int, dex, wis, con, cha and Gold) also render red, "Failure ()" text per roll.

image

@Stew-rt Stew-rt mentioned this issue May 29, 2023
Merged
anthonyronda added a commit that referenced this issue May 30, 2023
@anthonyronda
Merge pull request #448 from Stew-rt/character_generator_print_on_close
d14e45e 
fix(OseCharacterCreator): #424 - don't print on close, don't print Failure() on rolls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anthonyronda anthonyronda

Labels
bug Something isn't working chat Templating or logic inside a chat card good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@anthonyronda @metodi022 @Stew-rt