Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR for appcat on nextcloud-workload #605

Merged
merged 2 commits into from
Jan 17, 2025
Merged

PR for appcat on nextcloud-workload #605

merged 2 commits into from
Jan 17, 2025

Conversation

vshnbot
Copy link
Collaborator

@vshnbot vshnbot commented Jan 17, 2025

Summary

  • If string nextcloud is present in the workload name that the chart will not prepend "nextcloud" in the workload

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

Link: vshn/appcat#299

@zugao zugao added the patch label Jan 17, 2025
zugao
zugao approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zugao zugao merged commit 16707d8 into master Jan 17, 2025
10 checks passed
@zugao zugao deleted the appcat/299/nextcloud-workload branch January 17, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugao zugao zugao approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vshnbot @zugao