Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slos namespace #602

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Fix slos namespace #602

merged 1 commit into from
Jan 16, 2025

Conversation

zugao
Copy link
Contributor

@zugao zugao commented Jan 16, 2025

Thus PR fixes the name of our appcat slos namespace

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@zugao zugao added the patch label Jan 16, 2025
@zugao zugao requested review from a team, Kidswiss, TheBigLee and wejdross and removed request for a team January 16, 2025 13:19
Copy link
Member

@wejdross wejdross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would there be any issues if we migrate appcat-sla bucket? I think we only store data there, but does anything read from it?

@zugao
Copy link
Contributor Author

zugao commented Jan 16, 2025

Would there be any issues if we migrate appcat-sla bucket? I think we only store data there, but does anything read from it?

I don't think here is the right place. We can discuss this in an already opened ticket or a new one.

@zugao zugao merged commit 3a612ba into master Jan 16, 2025
10 checks passed
@zugao zugao deleted the fix-slos branch January 16, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants