WIP: Update/Fix Android Example for vsg 1.0 #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies - These changes are incomplete, this was a side-track from other work.
Raising a draft PR in case anyone can comment / help out with some of the old code. I think I've fixed the project side of things, and it should compile, once main.cpp is updated.
Only real issue I can see is use of outdated types (BufferDataList, vsg::Window::Traits rather than WindowTraits).
In another test project I also get a bad any_cast when passing the ANativeWindow* down to vsg through WindowTraits::nativeWindow, but I can't see any obvious reason why that would happen. Don't think that aspect has changed since the example was first written.