Skip to content

feat: add an option to disable Helm channel output#1208

Merged
Tatsinnit merged 3 commits intovscode-kubernetes-tools:masterfrom
okgolove:feature/supress-output-option
Oct 6, 2024
Merged

feat: add an option to disable Helm channel output#1208
Tatsinnit merged 3 commits intovscode-kubernetes-tools:masterfrom
okgolove:feature/supress-output-option

Conversation

@okgolove
Copy link
Copy Markdown
Contributor

This channel may be annoying a bit, especially when your yaml in values is not valid. supress-output option makes a user able to turn showing output Helm channel off

fixes #1137 #1100 #929 #907

This channel may be annoying a bit, especially when your yaml in values is not valid. supress-output option makes a user able to turn showing output Helm channel off

Signed-off-by: Mikhail Naletov <okgolove@markeloff.net>
Signed-off-by: Mikhail Naletov <okgolove@markeloff.net>
@okgolove
Copy link
Copy Markdown
Contributor Author

any chance this one will be reviewed?

@tlund101
Copy link
Copy Markdown

tlund101 commented Mar 4, 2024

Please. A log happens every time I do a git operation in the Terminal, which means I have to switch back to my terminal window constantly.

@corneliusroemer
Copy link
Copy Markdown

@corang
Copy link
Copy Markdown

corang commented Jun 3, 2024

Another bump, this is quite annoying without this PR

@paolofacchinetti
Copy link
Copy Markdown

also bumping this

At least expand on the error message to give additional context (i.e. file and line that's failing parsing), since the Unable to parse. message is useless and serves only to annoy developers

Unfortunately I had to disable the extension since this issue makes it unusable

@corneliusroemer
Copy link
Copy Markdown

Actually if the maintainers ignore this so long it means it effectively unmaintained.

Those who commented here should just get together on a fork. It would be usable again with just this fix.

@corneliusroemer
Copy link
Copy Markdown

@Tatsinnit could you please have a look? This bug is causing many people to disable the extension and I'm seriously considering making a fork that just includes this bug fix. This would be silly as you're still maintaining dependencies etc.

@Tatsinnit
Copy link
Copy Markdown
Collaborator

@Tatsinnit could you please have a look? This bug is causing many people to disable the extension and I'm seriously considering making a fork that just includes this bug fix. This would be silly as you're still maintaining dependencies etc.

Thanks, everyone! I’ve picked up this PR today and will be reviewing it within the next day or two. If everything looks good, we can move forward with merging. Looping in @squillace for visibility as well. <3

Apologies for the delay—had to prioritize a few other tasks. Big thanks to @corneliusroemer for the friendly reminder! <3

@Tatsinnit Tatsinnit added bug A bug in the extension. enhancement and removed bug A bug in the extension. labels Oct 4, 2024
Copy link
Copy Markdown
Collaborator

@Tatsinnit Tatsinnit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thank you so much for this!! Looks good to me, thanks heaps. I will merge this EOD today.

One minor question below please.

Comment thread package.json
remove duplicate types, and keep boolean.
@Tatsinnit Tatsinnit requested a review from squillace October 6, 2024 08:23
@Tatsinnit Tatsinnit merged commit 7d514ce into vscode-kubernetes-tools:master Oct 6, 2024
@okgolove okgolove deleted the feature/supress-output-option branch October 7, 2024 16:38
Tatsinnit pushed a commit to Tatsinnit/vscode-kubernetes-tools that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to parse. in output tab (Helm)

6 participants