remove every language we don't care about #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this actually ends up making our upgrade story significantly easier. i already have a branch on Bazel 0.26.x |
akakitani
reviewed
Sep 20, 2019
|
|
||
| load("//ruby:rules.bzl", "ruby_proto_repositories") | ||
|
|
||
| ruby_proto_repositories() |
akakitani
approved these changes
Sep 20, 2019
|
@akakitani iirc, relevant issue: golang/protobuf#547 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got sick of trying to make all the languages we don't actually use work... so I deleted everything except for closure, go, and gogo (maybe we might experiment with it one day!?).
This should make the footprint a lot smaller and maintenance a lot easier in the future.
Should we ever care for using one of those languages for protobuf, we shouldn't use rules_protobuf anyways in favor of whatever is the native Bazel rules.
build passed in: https://travis-ci.org/vsco/rules_protobuf/jobs/587324241