Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.0] VRM-1.0 の targetNames を Mesh.extras のみに修正 #1738

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

ousttrue
Copy link
Contributor

@ousttrue ousttrue commented Jul 12, 2022

#1739

targetName

下記参照のこと。

https://www.khronos.org/registry/glTF/specs/2.0/glTF-2.0.html#meshes

A significant number of authoring and client implementations associate names with morph targets. While the glTF 2.0 specification currently does not provide a way to specify names, most tools use an array of strings, mesh.extras.targetNames, for this purpose. The targetNames array and all primitive targets arrays must have the same length.

歴史的事情により、当初 primitive.extras.targetNames を使っていた。

KhronosGroup/glTF#1036

@ousttrue ousttrue requested a review from Santarh July 12, 2022 08:53
Copy link
Contributor

@Santarh Santarh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よし

@ousttrue ousttrue merged commit 7dce5db into vrm-c:master Jul 12, 2022
@ousttrue ousttrue deleted the fix10/remove_primitive_targetName branch January 24, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants