Calling correct delete function on deletion of gobj

[brianbbsu]

Info

Originally, the __del__ function of gobj called super(gcurve, self).__del__(), while gcurve is inherited from gobj, so gobj.__del__() is being called, again.

This caused an infinite loop, resulted in RecursionError, as the recursion depth limit of Python was hit.

I think this is a typo, and super(gobj, self).__del__() is what we expect.

Step to reproduce

Using the original code, the error can be reproduced with just two lines of code:

from vpython import *
curve1 = gcurve()

After closing the browser, Python deleted the curve1 object, and thus triggered the bug.

[mwcraig]

Thanks for the PR! Can you please also add your name to to contributors list here: https://github.com/vpython/vpython-jupyter/blob/master/CONTRIBUTORS.md

Feel free to enter

[brianbbsu]

Thanks for the PR! Can you please also add your name to to contributors list here: https://github.com/vpython/vpython-jupyter/blob/master/CONTRIBUTORS.md

Feel free to enter

Done.

Tell me if there's other things I can help. Thanks a lot.

[brianbbsu]

Oops, I don't know why 6294f4e failed to build, it's just a simple change on a text document.

[mwcraig]

Those seem to be conda problems, I've restarted those jobs.

[mwcraig]

Note to self: this line may be the underlying issue with the mac build, check with the conda folks about it: https://travis-ci.com/vpython/vpython-jupyter/jobs/246536941#L759

[brianbbsu]

Is there anything I can do to fix the issue?

[mwcraig]

If you want to try reproducing the error locally that would be great, but would require a Mac and setting up conda build. I'll have a bit of time to work on it over the weekend.

[mwcraig]

thanks again, @brianbbsu, I'm merging this! (The test failure was completely unrelated to anything in vpython)