Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register audio callback for WPC-EMU #173

Merged
merged 1 commit into from
Nov 19, 2019
Merged

Conversation

neophob
Copy link
Contributor

@neophob neophob commented Nov 19, 2019

  • register audio callback function (print out only)
  • bump wpc-emu to include fixed type definition

See #131.

- bump wpc-emu to include fixed type definition
@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #173 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #173      +/-   ##
==========================================
+ Coverage    90.8%   90.85%   +0.06%     
==========================================
  Files         272      272              
  Lines       14326    14494     +168     
  Branches     1672     1709      +37     
==========================================
+ Hits        13007    13167     +160     
- Misses        817      824       +7     
- Partials      502      503       +1
Impacted Files Coverage Δ
lib/emu/wpc-emu.ts 95.72% <100%> (+0.13%) ⬆️
lib/game/player.ts 87.06% <0%> (+0.4%) ⬆️
lib/vpt/ball/ball-hit.ts 77.5% <0%> (+0.84%) ⬆️
lib/vpt/table/table.ts 91.08% <0%> (+0.95%) ⬆️
lib/game/player-physics.ts 88.75% <0%> (+2.09%) ⬆️
lib/physics/hit-line-z.ts 88.89% <0%> (+4.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e107f4...fed4b5e. Read the comment docs.

@freezy freezy changed the title Step 1 to implement #131 Register audio callback for WPC-EMU Nov 19, 2019
@freezy freezy merged commit e5937f7 into master Nov 19, 2019
@freezy freezy deleted the feature/implement-audio-callback branch November 19, 2019 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants