rspec-puppet-facts: Require 3.0.0 #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
force-pushed
the
rpf
branch
2 times, most recently
from
bf8e78d
to
2e9936a
Compare
ekohl
reviewed
Mar 23, 2024
ekohl
reviewed
Mar 23, 2024
bastelfreak
force-pushed
the
rpf
branch
4 times, most recently
from
55e75dd
to
7ff571c
Compare
|
test at voxpupuli/puppet-example#51 |
bastelfreak
force-pushed
the
rpf
branch
2 times, most recently
from
08cc2ae
to
5415037
Compare
bastelfreak
added a commit
to bastelfreak/voxpupuli-test
that referenced
this pull request
May 24, 2024
Previously our tests didn't honour our spec/spec_helper.rb. This configures some rspec defaults for our Puppet modules. It makes sense that our tests use the same settings. This revealed some problems in other PRs: voxpupuli#125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to release this as breaking change. That will require us to do a modulesync. That in turns ensures that we've a PR and a CI run for each module before we pull this change in.