Rework GitHub Actions / release only on merges #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
force-pushed
the
dockerrrrrrrr
branch
3 times, most recently
from
980a249 to
650137a
Compare
|
New login is failing. Perhaps the credentials are not available? |
bastelfreak
force-pushed
the
dockerrrrrrrr
branch
from
650137a to
4094c1f
Compare
bastelfreak
changed the title
With this PR we rework our GitHub actions and split them into two. One is triggered for pull requests and executes our tests. The second one runs for merges onto master. It executes the test as well but also builds the docker image and pushes it to DockerHub.
bastelfreak
force-pushed
the
dockerrrrrrrr
branch
from
4094c1f to
aceacd6
Compare
|
@ghoneycutt the old setup failed because this PR comes from my work. the github secrets are only available for PR from this repo. I reworked the actions and adjusted the PR title/description at the top. |
ghoneycutt
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we rework our GitHub actions and split them into two. One
is triggered for pull requests and executes our tests. The second one
runs for merges onto master. It executes the test as well but also
builds the docker image and pushes it to DockerHub.