Add support for defining host's macros #671
Conversation
|
Dear @zv0n, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
1 similar comment
|
Dear @zv0n, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
bastelfreak
added
enhancement
|
thanks for the work @zv0n. can you please rebase? |
|
Hi, |
|
@zv0n can you please fix the failing travis job? |
|
Hi, |
manifests/agent.pp
Outdated
| @@ -249,6 +252,7 @@ | |||
| Variant[String[1],Array[String[1]]] $zbx_groups = $zabbix::params::agent_zbx_groups, | |||
| $zbx_group_create = $zabbix::params::agent_zbx_group_create, | |||
| $zbx_templates = $zabbix::params::agent_zbx_templates, | |||
| Optional[Array[Hash]] $zbx_macros = $zabbix::params::agent_zbx_macros, | |||
There was a problem hiding this comment.
for arrays we try to use [] as default, or {} for hashes. In that case we won't need the Optional part. I think that would be possible here was well?
We've more of our review guidelines available at https://voxpupuli.org/docs/reviewing_pr/
manifests/agent.pp
Outdated
| @@ -249,6 +252,7 @@ | |||
| Variant[String[1],Array[String[1]]] $zbx_groups = $zabbix::params::agent_zbx_groups, | |||
| $zbx_group_create = $zabbix::params::agent_zbx_group_create, | |||
| $zbx_templates = $zabbix::params::agent_zbx_templates, | |||
| Array[Hash] $zbx_macros = $zabbix::params::agent_zbx_macros, | |||
There was a problem hiding this comment.
| Array[Hash] $zbx_macros = $zabbix::params::agent_zbx_macros, | |
| Array[Hash] $zbx_macros = [], |
manifests/params.pp
Outdated
| @@ -317,6 +317,7 @@ | |||
| $agent_zbx_templates = [ | |||
| 'Template OS Linux', | |||
| 'Template App SSH Service'] | |||
| $agent_zbx_macros = undef | |||
|
Looks like the job failed because there was a problem problem when connecting to the container, should I do something or is the pull request ok now? |
|
I restarted the job |
Pull Request (PR) description
This commit adds support for defining custom macros for zabbix hosts