Feature/acceptance test custom types #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Dec 15, 2018
|
God dammit... It worked on my machine without issues... No idea why its breaking in Travis :( Will have a closer look on monday. |
baurmatt
force-pushed
the
feature/acceptance_test_custom_types
branch
from
ea54262 to
10923ac
Compare
|
#576 should fix the rest of the failing tests. |
baurmatt
force-pushed
the
feature/acceptance_test_custom_types
branch
from
10923ac to
b93276d
Compare
bastelfreak
reviewed
Dec 21, 2018
| @@ -267,13 +267,19 @@ | |||
| # "Warning: You cannot collect without storeconfigs being set" | |||
| if $manage_resources { | |||
| include ruby::dev | |||
| $compile_packages = $facts['os']['family'] ? { | |||
|
thanks for the awesome work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR adds acceptance tests for the zabbix_ custom types.
Beaker is setting up a server with Zabbix database, server and webfrontend and creates the zabbix_* resources. I had to created a custom ServerSpec::Types to interact with the Zabbix API because we can't access it within Beaker by e.g. zabbixapi gem.
This was done to ensure the changes in #570 don't break the custom types.
This Pull Request (PR) fixes the following issues