Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure future compatibility with systemd #740

Closed
theo-meow opened this issue Feb 23, 2021 · 3 comments
Closed

Ensure future compatibility with systemd #740

theo-meow opened this issue Feb 23, 2021 · 3 comments

Comments

@theo-meow
Copy link
Contributor

theo-meow commented Feb 23, 2021

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: Any
  • Ruby: Any
  • Distribution: Any, using Systemd
  • Module version: 8.0.0, master

Any additional information you'd like to impart

This is really just a heads-up.
In a recent commit on the puppet module "systemd" which is a dependency for this module, the code that creates the resource Exec[systemctl-daemon-reload] is dropped.
This causes any node that has the zabbix::agent class to fail with the error message listed below.

Commit in question:
voxpupuli/puppet-systemd@97dd16f

How to reproduce (e.g Puppet code you use)

Check out master branch of camptocamp/systemd, deploy node with class { 'zabbix::agent' ... configured.

What are you seeing

Failure to compile catalog, since the resource Exec[systemctl-daemon-reload] is missing.

What behaviour did you expect instead

The dependency being met.

Output log

2021-02-23T14:18:26.858+01:00 ERROR [qtp1804988349-2269] [puppetserver] Puppet Could not find resource 'Exec[systemctl-daemon-reload]' for relationship from 'File[/etc/systemd/system/zabbix-agent.service]' on node ((redacted))

@tuxmea
Copy link
Member

tuxmea commented Mar 4, 2021

There are two possible solutions:

  1. remove the notify on the exec daemon-reload and drop support for puppet < 6.1
  2. add the exec resource and keep compatibility with puppet < 6.1

Which solution do we prefer?
@bastelfreak @0none

@root-expert
Copy link
Member

It's being addressed here #742 . Not ready though

@rwaffen
Copy link
Member

rwaffen commented Apr 19, 2021

it looks ready now, ran into the same problem and tested master from this module and it is working again.

@kenyon kenyon closed this as completed Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants