-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional parameters to groupinstall #86
Conversation
manifests/group.pp
Outdated
@@ -20,6 +21,7 @@ | |||
define yum::group ( | |||
Enum['present', 'installed', 'absent', 'purged'] $ensure = 'present', | |||
Optional[Integer] $timeout = undef, | |||
Optional[Array[String]] $install_options = [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be Optional
if the default value is []
and there's not logic to check if it's Undef
?
Hi @jfroche, thanks for this PR. Can you remove the Optional around the datatypes and please enhance the README.md with this new parameter? |
Could the option --setopt also be added? as described in Why yum groupinstall "" is failing on RHEL 7 with error "There is no installed groups file" ? (https://access.redhat.com/solutions/1310043) yum groups install "System Management" --setopt=group_package_types=mandatory,default,optional |
No need to change anything. I can use it with the install_options |
e7d78df
to
917fd35
Compare
@bastelfreak Optional datatype has been removed for the install_options array, and documentation has been added. |
We want to install a group using an extra repository not enabled by default. We can now enable that extra repository during group install using the `install_options` parameter. E.g.: yum::group { 'mate-desktop-environment': ensure => present, install_options => ['--enablerepo=epel'] }
352bbc5
to
b68363e
Compare
thanks for the update! |
We want to install a group using an extra repository not enabled by
default.
We can now enable that extra repository during group install using the
install_options
parameter.E.g.:
yum::group {
'mate-desktop-environment':
ensure => present,
install_options => ['--enablerepo=epel']
}