Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional parameters to groupinstall #86

Merged
merged 5 commits into from
Mar 6, 2019

Conversation

jfroche
Copy link

@jfroche jfroche commented Jan 11, 2018

We want to install a group using an extra repository not enabled by
default.
We can now enable that extra repository during group install using the
install_options parameter.

E.g.:

yum::group {
'mate-desktop-environment':
ensure => present,
install_options => ['--enablerepo=epel']
}

@@ -20,6 +21,7 @@
define yum::group (
Enum['present', 'installed', 'absent', 'purged'] $ensure = 'present',
Optional[Integer] $timeout = undef,
Optional[Array[String]] $install_options = [],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be Optional if the default value is [] and there's not logic to check if it's Undef?

@bastelfreak bastelfreak added enhancement New feature or request needs-docs labels Jan 27, 2018
@bastelfreak
Copy link
Member

Hi @jfroche, thanks for this PR. Can you remove the Optional around the datatypes and please enhance the README.md with this new parameter?

@wernermaes
Copy link

Could the option --setopt also be added?

as described in Why yum groupinstall "" is failing on RHEL 7 with error "There is no installed groups file" ? (https://access.redhat.com/solutions/1310043)

yum groups install "System Management" --setopt=group_package_types=mandatory,default,optional

@wernermaes
Copy link

No need to change anything. I can use it with the install_options

yorickps added a commit to kuleuven/puppet-yum that referenced this pull request Mar 6, 2019
@yorickps yorickps force-pushed the groupinstall-options branch from e7d78df to 917fd35 Compare March 6, 2019 12:44
@yorickps
Copy link

yorickps commented Mar 6, 2019

@bastelfreak Optional datatype has been removed for the install_options array, and documentation has been added.

jfroche and others added 5 commits March 6, 2019 21:50
We want to install a group using an extra repository not enabled by
default.
We can now enable that extra repository during group install using the
`install_options` parameter.

E.g.:

  yum::group {
    'mate-desktop-environment':
      ensure          => present,
      install_options => ['--enablerepo=epel']
  }
@bastelfreak
Copy link
Member

thanks for the update!

@bastelfreak bastelfreak merged commit 494981f into voxpupuli:master Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants