BREAKING: Config create resources pattern #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lamawithonel
force-pushed
the
config_create_resources_pattern
branch
from
54f13cc to
28b0c8f
Compare
lamawithonel
changed the title
lamawithonel
force-pushed
the
config_create_resources_pattern
branch
3 times, most recently
from
1e14259 to
b9b6edb
Compare
This commit sets the data provider to Hiera. A previous update added the `hiera.yaml` file and `/data` directories, but they have not actually been used. It went unnoticed, because they were empty. Fixing this allows future changes to use the module data system.
lamawithonel
force-pushed
the
config_create_resources_pattern
branch
4 times, most recently
from
8a9abf3 to
caa7c54
Compare
This commit implements the `create_resources()` pattern for
`Yum::Config` defined types using Puppet 4 features. The
`create_resources()` pattern takes a Hash of resource names and their
attributes and iterates over them to declare a set of resources.
Because this pattern allows virtually any `yum.conf(5)` option to be
passed to the module, this commit also removes most of the default
`Yum::Config` resources. The only exception is `installonly_limit`,
which is retained for resource dependency resolution with
`Exec['package-cleanup_oldkernels']`, however the default value was
modified to match the upstream default.
In addition to standard `key => { hash_of_attributes }`, the new
parameter interface also accepts a more streamlined `key => value`
syntax. Further, values defined as a Boolean will be converted to
Strings, either `0` or `1`.
lamawithonel
force-pushed
the
config_create_resources_pattern
branch
from
caa7c54 to
2247439
Compare
cmentzer
approved these changes
Feb 1, 2017
traylenator
added
backwards-incompatible
enhancement
traylenator
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to address #36.