Finish out dnf path for versionlock. #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a reasonable implementation to me. |
op-ct
approved these changes
Jun 17, 2022
trevor-vaughan
approved these changes
Jun 17, 2022
|
This breaks a lot of rspec referencing yum::versionlock where the provider fact is not set. Could we use OS version in hiera or add a default to common.yaml? |
traylenator
added a commit
to traylenator/puppet-yum
that referenced
this pull request
Jun 20, 2022
With the changes in voxpupuli#253 `yum::versionlock` was failing for cases where `$facts['package_provider]` which is typically the case for rspec compilations. Default `yum::versionlock::path` to the existing yum location.
traylenator
added a commit
to traylenator/puppet-yum
that referenced
this pull request
Jun 20, 2022
With the changes in voxpupuli#253 `yum::versionlock` was failing for cases where `$facts['package_provider]` which is typically the case for rspec compilations. Default `yum::versionlock::path` to the existing yum location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
The versionlock file used by the module actually points to the wrong place on
dnfbased systems. This should fix that up and add a parameter to make it easier to set locks/actions.This Pull Request (PR) fixes the following issues
n/a