require
(not contain
) yum::plugin::versionlock
#154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin class
yum::plugin::versionlock
should not becontain
edfrom every instance of the
yum::versionlock
defined type. Doing somakes it impossible to use the type in multiple dependent
classes/profiles.
contain
implies that the resource 'owns' the plugin.Using
require
should be just as effective at solving #43 withoutintroducing dependency cycles.
With
contain
...fails with
This commit also refactors the type with:
unless
instead of acase
forensure
.assert_type
instead ofis_a
.Fixes #43