Support ensuring all yum group packages are installed #140
Conversation
| if $ensure == 'latest' { | ||
| exec { "yum-groupinstall-${name}-latest": | ||
| command => join(concat(["yum -y groupinstall '${name}'"], $install_options), ' '), | ||
| onlyif => "yum groupinfo '${name}' | egrep '\\s+\\+'", |
There was a problem hiding this comment.
Can you please explain what you're expecting to filter with egrep
There was a problem hiding this comment.
The logic is looking for +package in the list from groupinfo. If there is no package with + (plus sign) then all packages in the package group are installed and it's not necessary to run yum groupinstall. If a package in the package list has + then it is in the group but not installed on the system so yum groupinstall will ensure all packages get installed.
The existing Exec covers the initial install but the output from yum grouplist hidden $group does not change if some packages are added to a group after it's installed. This PR covers that case.
There was a problem hiding this comment.
Please comment what the regex is meant to do above the regex.
|
I've applied this PR to my environment where I had a local package group installed. I then added 2 packages to that group and ran Puppet and this change allowed my systems to pick up that package group update and install the new additions to the group. Before this change I'd have to manually install additional packages via something like mcollective. |
|
I like it. 👍 |
|
@othalla Correct, latest just ensures the entire group is installed, doesn't check to see if they are the newest version. |
|
Any update on getting this merged? |
|
@bastelfreak what do you think? |
| if $ensure == 'latest' { | ||
| exec { "yum-groupinstall-${name}-latest": | ||
| command => join(concat(["yum -y groupinstall '${name}'"], $install_options), ' '), | ||
| onlyif => "yum groupinfo '${name}' | egrep '\\s+\\+'", |
There was a problem hiding this comment.
Please comment what the regex is meant to do above the regex.
Pull Request (PR) description
Update
yum::groupto have additional state oflatestthat will ensure all mandatory packages of a group are always installed.When a mandatory package is not installed for a group that is installed it will be prefixed with
+. Without this change any changes to a mandatory package list would never get installed without manual intervention.We use package groups to ensure baseline package list and it's much faster to apply one package group than dozens of individual Package resources.