Amazon Linux manage_os_default_repos does not compile due to unsupported parameters

[Zordrak]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 5.5.1
• Ruby: 2.4.4
• Distribution: Amazon Linux
• Module version: 2.2.1

How to reproduce (e.g Puppet code you use)

node default {
  lookup('classes', {merge => unique}).include
}

classes:
  - yum
yum::manage_os_default_repos: true

What are you seeing

Failure to configure Amazon Linux default puppet repos due to the setting of parameters that Yumrepo does not support, such as fastestmirror_enabled and report_instanceid

What behaviour did you expect instead

Amazon default yum repos successfully configured

Output log

Error: no parameter named 'fastestmirror_enabled' (file: /etc/puppetlabs/code/environments/mot2/modules/yum/manifests/init.pp, line: 130) on Yumrepo[amzn-main] (file: /etc/puppetlabs/code/environments/mot2/modules/yum/manifests/init.pp, line: 130)

[Zordrak]

I'm looking into a PR for puppet to support fastestmirror_enabled and report_instanceid.

However, despite the fact that the amazon default repo configuration contains the parameter fastestmirror_enabled, and Chef already supports it - I have not been able to find any code or documentation in yum or the fastestmirror plugin for yum that suggests it supports enable/disable at the per-repository level.

[Zordrak]

https://tickets.puppetlabs.com/browse/PUP-8730
puppetlabs/puppet#6834

[Zordrak]

Based upon the result of https://tickets.puppetlabs.com/browse/PUP-8730 being Won'tFix, instead raising https://tickets.puppetlabs.com/browse/PUP-8904 to modify the Yumrepo type for implementation in Puppet 6, I would like to request that until such time as there is a valid way to define these unsupported paramaters, they be removed from the current data file for Amazon Linux in this module so that this module's basic functionality can still be used to manage the default repos in Amazon Linux.

@bastelfreak @pillarsdotnet

[Zordrak]

PR opened to fix: https://github.com/voxpupuli/puppet-yum/pull/103/files