Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display parser.failure_reason when there's a failure. #242

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

kwolf-zz
Copy link
Contributor

@kwolf-zz kwolf-zz commented May 25, 2018

This is closely tied to PR #241 but I wanted to submit it separately incase you didn't want it... It's definitely optional, but nice to have.

While debugging the Treetop parse errors we were having, this was very helpful. Doesn't generate anymore logging until there is an exception raised.

@coveralls
Copy link

coveralls commented May 25, 2018

Coverage Status

Coverage remained the same at 74.385% when pulling 9ff762d on kwolf:show_failure_reason into acba51c on biemond:master.

@jairojunior
Copy link
Collaborator

Great. Thank you.

@jairojunior jairojunior merged commit 184f088 into voxpupuli:master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants