Skip to content

Handle rabbitmq.config when cluster_nodes is empty #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2024
Merged

Handle rabbitmq.config when cluster_nodes is empty #993

merged 1 commit into from
May 20, 2024

Conversation

@nosrio
Copy link
Contributor

@nosrio nosrio commented May 20, 2024 •
edited by wyardley
Loading

Pull Request (PR) description

Fix cluster config when cluster_nodes is empty

Followup to #978

@nosrio
Copy link
Contributor Author

nosrio commented May 20, 2024

Hi @wyardley, could you pleae re run github action?
I believe that the timeout error is not related to my change.

@wyardley wyardley added the bug Something isn't working label May 20, 2024
@wyardley
Copy link
Contributor

Rerunning
Can you reference the original PR / commit this was related to (#978) in the commit message?

@wyardley
Copy link
Contributor

Also, can you double-check that the email you're using for commits is tied to your GitHub username and / or amend the author on your commit?
Your profile doesn't show up in the UI next to the commit

image

@nosrio nosrio force-pushed the FixClusterNodesConfig branch from ab854b2 to aaa46be Compare May 20, 2024 15:24
wyardley
wyardley approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@wyardley wyardley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
If you are able to implement a unit test that would have caught this issue (could be a followup PR if you'd like to get this out fast), that would also be excellent.

@nosrio
Copy link
Contributor Author

nosrio commented May 20, 2024

Done

@wyardley wyardley merged commit 55a0fd5 into voxpupuli:master May 20, 2024
@wyardley
Copy link
Contributor

I will try to get this out soon, probably after I get someone to look at #991 and then once I can get approval on a release PR

nosrio added a commit to nosrio/puppet-rabbitmq that referenced this pull request May 20, 2024
@nosrio
Add unit test to handle bug solved on PR voxpupuli#993
40392c9
@nosrio nosrio mentioned this pull request May 20, 2024
Merged
nosrio added a commit to nosrio/puppet-rabbitmq that referenced this pull request May 20, 2024
@nosrio
Add unit test to handle bug solved on PR voxpupuli#993
e96d12e 
fix identation
wyardley added a commit that referenced this pull request May 20, 2024
@wyardley
Merge pull request #994 from nosrio/AddUnitTest
137edee 
Add unit test to handle bug solved on PR #993
@wyardley wyardley mentioned this pull request May 23, 2024
Merged
wyardley pushed a commit that referenced this pull request Nov 14, 2024
@nosrio @wyardley
Add unit test to handle bug solved on PR #993
8bd94b8 
fix identation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyardley wyardley wyardley approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nosrio @wyardley