Skip to content

Conversation

@wyardley
Copy link
Contributor

Pull Request (PR) description

Resolve deprecation errors by using ensure_packages() from stdlib vs. from Puppet

  Warning: This function is deprecated, please use stdlib::ensure_packages instead. at ["/etc/puppetlabs/code/environments/production/modules/rabbitmq/manifests/install/rabbitmqadmin.pp", 14]:["/etc/puppetlabs/code/environments/production/modules/rabbitmq/manifests/init.pp", 574]

This Pull Request (PR) fixes the following issues

@wyardley wyardley requested a review from bastelfreak May 19, 2024 18:19
@wyardley
Copy link
Contributor Author

@bastelfreak does this make sense? seems like ensure_packages existed even in the oldest version we support?

So far, I didn't see any other deprecated stdlib methods? Not sure if you'd like to increase the min version for it anyway as a breaking change?

@wyardley wyardley added the bug Something isn't working label May 19, 2024
@TheMeier
Copy link
Contributor

replacing ensure_packages by stdlib::ensure_packages makes perfectly sense

@wyardley wyardley merged commit 6011c2d into voxpupuli:master May 19, 2024
@wyardley wyardley deleted the wyardley/ensure_packages_stdlib branch May 19, 2024 19:06
@wyardley wyardley mentioned this pull request May 23, 2024
@wyardley wyardley removed the bug Something isn't working label May 23, 2024
@bastelfreak bastelfreak changed the title Use ensure_packages from stdlib Use stdlib::ensure_packages May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants