BREAKING: Drop official Archlinux support #933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop official metadata.json support for Archlinux until the acceptance tests can be fixed
Replace legacy :osfacts with facts[:os]['family'] Signed-off-by: William Yardley <[email protected]>
wyardley
commented
May 12, 2023
There was a problem hiding this comment.
I'm thinking to leave the spec tests in place for now vs. ripping them out? There's some risk of drift or problems from them being there but not run, but on the other hand, would be a pain to add them back later.
Not sure if there's a way with the current Vox tooling to not run the acceptance tests but still run the spec tests or if that would be worth doing...
bastelfreak
approved these changes
May 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues