Support FreeBSD 12 and 13 #932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wyardley
force-pushed
the
wyardley/freebsd
branch
from
abbce5b to
6de4999
Compare
Update tests and metadata to support FreeBSD 12 and 13 This also helps us unit test the (otherwise untested) conditionals related to systems without systemd We may still need to tweak the current python package name, but this is a start Per @bastelfreak's suggestion, use os_facts to avoid confusion with :facts Signed-off-by: William Yardley <[email protected]>
wyardley
force-pushed
the
wyardley/freebsd
branch
from
6de4999 to
8f5421a
Compare
wyardley
commented
May 11, 2023
| it { is_expected.to contain_package('python') } if %w[RedHat Debian SUSE Archlinux].include?(facts[:os]['family']) | ||
| it { is_expected.to contain_package('python2') } if %w[FreeBSD OpenBSD].include?(facts[:os]['family']) | ||
| it { is_expected.to contain_package('python') } if %w[RedHat Debian SUSE Archlinux].include?(os_facts[:os]['family']) | ||
| it { is_expected.to contain_package('python38') } if %w[FreeBSD].include?(os_facts[:os]['family']) |
There was a problem hiding this comment.
note: this may have changed by now - not sure. but at least it matches the current stuff in data, and can be adjusted in tests later if needed
wyardley
commented
May 11, 2023
| context "on #{os}" do | ||
| let :facts do | ||
| facts | ||
| os_facts |
There was a problem hiding this comment.
@bastelfreak this (and associated changes) is what you had in mind, right?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Update tests and metadata to support FreeBSD 12 and 13 This also helps us unit test the (otherwise untested) conditionals related to systems without systemd
We may still need to tweak the current python package name, but this is a start
Per @bastelfreak's suggestion, use
os_factsto avoid confusion with:factsThis Pull Request (PR) fixes the following issues