Skip to content

Conversation

@fatpat
Copy link
Contributor

@fatpat fatpat commented Feb 17, 2023

Pull Request (PR) description

When overriding local node name (using NODENAME environment variable), clustering does not work as tinit_node is tested again hostname or fqdn. By adding the optional local_node to specify which node is the current node we can fix this issue.

Use case: a server with a public and a private interface, rabbitmq cluster nodes communicates through the private interface while hostname and fqdn resolves to the public interface (and that can't be changed because of other dependencies on the server). The only solution is to use dedictated name for the private interface.

@fatpat fatpat force-pushed the cluster_add_local_node branch from d5da122 to 4a5fc05 Compare February 17, 2023 09:04
Copy link
Contributor

@wyardley wyardley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi - thanks for the PR
Sorry for the delay in reviewing it. Overall, I think this makes sense.

Few minor comments. Also, can you reset the changes to REFERENCE.md? We can rebuild it when cutting the next release.

Question: your commit seems to be from @openiobot - can you amend the author to be your own GH username?

@fatpat fatpat force-pushed the cluster_add_local_node branch 3 times, most recently from d14fe3d to 4ce0862 Compare March 3, 2023 05:09
@fatpat
Copy link
Contributor Author

fatpat commented Mar 3, 2023

Hi - thanks for the PR Sorry for the delay in reviewing it. Overall, I think this makes sense.

Few minor comments. Also, can you reset the changes to REFERENCE.md? We can rebuild it when cutting the next release.

Question: your commit seems to be from @openiobot - can you amend the author to be your own GH username?

  • REFERENCE.md changes have been reverted
  • authors has been fixed
  • empty default value has been fixed

@wyardley
Copy link
Contributor

wyardley commented Mar 4, 2023

@fatpat I must have been speaking on outdated information :/ Sorry about that. Looks like the current CI checks want REFERENCE.md to be up to date.

@fatpat fatpat force-pushed the cluster_add_local_node branch from 4ce0862 to e88ccfd Compare March 4, 2023 08:23
@fatpat
Copy link
Contributor Author

fatpat commented Mar 4, 2023

fixed

When overriding local node name (using NODENAME environment variable),
clustering does not work as tinit_node is tested again hostname or
fqdn. By adding the optional local_node to specify which node is the
current node we can fix this issue.

Use case: a server with a public and a private interface, rabbitmq
cluster nodes communicates through the private interface while hostname
and fqdn resolves to the public interface (and that can't be changed
because of other dependencies on the server). The only solution is to
use dedictated name for the private interface.
@fatpat fatpat force-pushed the cluster_add_local_node branch from e88ccfd to 119108d Compare March 4, 2023 11:07
@wyardley wyardley merged commit 45128cf into voxpupuli:master Mar 6, 2023
@wyardley wyardley added the enhancement New feature or request label Mar 6, 2023
@wyardley wyardley mentioned this pull request May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants