Use mocked facts in tests #873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the add_mocked_facts! from voxpupuli-test 2.2.0 rather than a local override.
bastelfreak
approved these changes
Feb 23, 2021
wyardley
added a commit
to wyardley/puppet-rabbitmq
that referenced
this pull request
Apr 16, 2021
- Add support for oom_score_adj (voxpupuli#877) - CLI Environment Fixes (voxpupuli#876) - make sure the rabbitmq_version method actually returns the version (voxpupuli#874) - Use mocked facts in tests (voxpupuli#873)
Merged
wyardley
added a commit
to wyardley/puppet-rabbitmq
that referenced
this pull request
Apr 16, 2021
- Add support for oom_score_adj (voxpupuli#877) - CLI Environment Fixes (voxpupuli#876) - make sure the rabbitmq_version method actually returns the version (voxpupuli#874) - Use mocked facts in tests (voxpupuli#873) - Enable Puppet 7 support (voxpupuli#881)
wyardley
added a commit
to wyardley/puppet-rabbitmq
that referenced
this pull request
Apr 20, 2021
- Add support for oom_score_adj (voxpupuli#877) - CLI Environment Fixes (voxpupuli#876) - make sure the rabbitmq_version method actually returns the version (voxpupuli#874) - Use mocked facts in tests (voxpupuli#873) - Enable Puppet 7 support (voxpupuli#881) - Add auto cluster configuration support (voxpupuli#883)
wyardley
added a commit
to wyardley/puppet-rabbitmq
that referenced
this pull request
May 6, 2021
- Add support for oom_score_adj (voxpupuli#877) - CLI Environment Fixes (voxpupuli#876) - make sure the rabbitmq_version method actually returns the version (voxpupuli#874) - Use mocked facts in tests (voxpupuli#873) - Enable Puppet 7 support (voxpupuli#881) - Add auto cluster configuration support (voxpupuli#883)
wyardley
added a commit
to wyardley/puppet-rabbitmq
that referenced
this pull request
May 6, 2021
- Add support for oom_score_adj (voxpupuli#877) - CLI Environment Fixes (voxpupuli#876) - make sure the rabbitmq_version method actually returns the version (voxpupuli#874) - Use mocked facts in tests (voxpupuli#873) - Enable Puppet 7 support (voxpupuli#881) - Add auto cluster configuration support (voxpupuli#883) - Compatibility with camptocamp/systemd 3.x (voxpupuli#886)
wyardley
added a commit
to wyardley/puppet-rabbitmq
that referenced
this pull request
May 6, 2021
- Add support for oom_score_adj (voxpupuli#877) - CLI Environment Fixes (voxpupuli#876) - make sure the rabbitmq_version method actually returns the version (voxpupuli#874) - Use mocked facts in tests (voxpupuli#873) - Enable Puppet 7 support (voxpupuli#881) - Add auto cluster configuration support (voxpupuli#883) - Compatibility with camptocamp/systemd 3.x (voxpupuli#886) - puppetlabs/apt: Allow 8.x (voxpupuli#884) - puppet/archive: Allow 5.x (voxpupuli#884) - puppetlabs/stdlib: allow 7.x (voxpupuli#884)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the add_mocked_facts! from voxpupuli-test 2.2.0 rather than a local override.
A result of what voxpupuli/modulesync_config#693 would do.