Handle case when virtualenv_version fact is not available. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As specified in voxpupuli#94, when their is no way to find virtualenv version, fall back to user request. When fact virtualenv_version is not yet available, stupidly trust user input and force systempkgs options without taking care of virtualenv veresion. 1. If the option choosen is not recognized by the installed version of virtualenv, further Exec will fail and dependencies will not be processed. 2. On the next puppet execution, fact _virtualenv_version_ will be available and process should work as expected.
stankevich
added a commit
that referenced
this pull request
Jul 24, 2014
Handle case when virtualenv_version fact is not available.
stankevich
added a commit
that referenced
this pull request
Sep 1, 2015
Handle case when virtualenv_version fact is not available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified in #94, when their is no way to find virtualenv version,
fall back to user request.
When fact virtualenv_version is not yet available, stupidly trust user
input and force
systempkgsoption without taking care of virtualenvversion.
--no-site-packagesor--system-site-packagesis not recognized by the installed version ofvirtualenv, Exec will fail and dependencies will not be processed (this will avoid some services to actually seem to work and some times later fail because of the lack of system site packages).
expected.