Add OracleLinux/AlmaLinux/Rocky support #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reopening to rerun the tests, since the CentOS ones failed due to a timeout. |
|
Timed out again. We see this on other repos too and had some discussion about it here: https://puppetcommunity.slack.com/archives/C0W1Y5VL0/p1699957763125089 Also forgot that we don't need to close and reopen to rerun failed tests, can rerun the failed tests from the GitHub Actions job status interface. |
…9 to metadata.json operatingsystem_support array
kenyon
approved these changes
Nov 27, 2023
|
@kenyon I would just rename it to 'Add OracleLinux/AlmaLinux/Rocky support'. Are you fine with that? I don't consider this a bugfix becaue we never claimed to support those in the first place. |
kenyon
changed the title
|
@bastelfreak good idea, I updated the PR title. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Newer(8+) RedHat family OSes do not package python-venv as it is built in to the versions of Python they ship
This Pull Request (PR) fixes the following issues
n/a