Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use $real_pkgname for pip uninstall command #607

Merged
merged 7 commits into from
Apr 28, 2021
Merged

Use $real_pkgname for pip uninstall command #607

merged 7 commits into from
Apr 28, 2021

Conversation

brabiega
Copy link
Contributor

Fix #606

Pull Request (PR) description

Use $real_pkgname for pip uninstall command

This Pull Request (PR) fixes the following issues

Fixes #606

kenyon
kenyon approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to also add a test for this so that it doesn't break again.

@brabiega
Copy link
Contributor Author

I've added the test, should be enough.

@bastelfreak bastelfreak added bug Something isn't working needs-tests labels Apr 26, 2021
@brabiega
Copy link
Contributor Author

I guess system wide pip path may differ on different OSes.
/usr/bin/pip - this is not universal.

I'll fix the acceptance tests to run pip inside virtualenv.

@bastelfreak bastelfreak merged commit 50886bf into voxpupuli:master Apr 28, 2021
@brabiega brabiega deleted the patch-1 branch April 29, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastelfreak bastelfreak bastelfreak left review comments

@kenyon kenyon kenyon approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pip uninstall does not support pkgname variable
3 participants
@brabiega @kenyon @bastelfreak