Set default python to 3 #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
changed the title
|
I was considering setting the default python version on CentOS 7 to python 2. The issue is that we don't test against python 2 since a long time. If I enable python 2 acceptance tests they fail, also python 2 is end of life and centos 7 ships python 3, so it should be used. |
bastelfreak
force-pushed
the
cleanup
branch
4 times, most recently
from
fd75dde to
aeea580
Compare
The whole virtualenv setup is deprecated upstream. pyvenv / the built-in python module venv should be used. Since we already have a few backwards incompatible changes on master, it makes sense to drop this now.
debian sometimes takes a bit longer in CI to pass, this fixes it.
kenyon
approved these changes
Dec 15, 2020
|
Ubuntu 20 / Puppet 5 failures are expected because Puppet does not provide packages for that platform combination. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues