Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ubuntu 20.04 #593

Merged
merged 10 commits into from
Dec 14, 2020
Merged

Support Ubuntu 20.04 #593

merged 10 commits into from
Dec 14, 2020

Conversation

treydock
Copy link
Contributor

Pull Request (PR) description

Add support for Ubuntu 20.04. Had to force virtualenv to not use distribute otherwise produces errors. Also updated virtualenv tests to consistently use Python 3 since first set of tests did this but subsequent tests did not and that broke some OS acceptance tests.

This Pull Request (PR) fixes the following issues

Replaces #576

@treydock
Copy link
Contributor Author

Looks like the Ubuntu 20.02 & Puppet 5 acceptance failure was networking issues boostrapping the beaker nodeset. Will need to be rerun.

@bastelfreak
Copy link
Member

Ubuntu 29 + puppet 5 is expected to fail because puppet does not provide packages fro them :(

@treydock
Copy link
Contributor Author

Looks like majority of tests are failing virtualenv with this error:

       	Notice: /Stage[main]/Main/Python::Virtualenv[venv]/Exec[python_virtualenv_/opt/venv6]/returns:     AttributeError: module 'importlib._bootstrap' has no attribute 'SourceFileLoader'

After much googling at least with Ubuntu 20.04 the online solutions did not work. The only way around it was not trying to install distribute pip package so forcing distribute => false for python::virtualenv. I'm wondering if that should become the new default because majority of OSes with Python 3 seem to not work with distribute => true.

manifests/pyvenv.pp Outdated Show resolved Hide resolved
@treydock
Copy link
Contributor Author

@bastelfreak I am not real familiar with how voxpupuli modulesync sets up setfiles for acceptance, my exclude didn't seem to take. I think the hash used to define matrix causes issues with being able to exclude elements

@bastelfreak
Copy link
Member

we havn't figured out yet how to exclude sets :(

Copy link
Member

@bastelfreak bastelfreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, but will keep it open for a day or two so others can review it as well

@bastelfreak
Copy link
Member

@crazymind1337 can you take a look as well?

@bastelfreak
Copy link
Member

@treydock can you rebase against master to get rid of the merge commit?

@treydock
Copy link
Contributor Author

@bastelfreak I had done a merge to get in the virtualenv unit tests which needed to be adjusted for this pull request. Looks to have resolved the conflicts.

manifests/install.pp Outdated Show resolved Hide resolved
manifests/params.pp Outdated Show resolved Hide resolved
manifests/pyvenv.pp Show resolved Hide resolved
@crazymind1337
Copy link
Member

crazymind1337 commented Dec 14, 2020

Tested on latest ubuntu:20.04 docker container with puppet6. Works for me!

@crazymind1337
Copy link
Member

@treydock You still have to fix the Commit messages. It looks like there is something wrong.

@crazymind1337
Copy link
Member

@treydock You still have to fix the Commit messages. It looks like there is something wrong.

Nevermind. I will squash it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants