-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Ubuntu 20.04 #593
Support Ubuntu 20.04 #593
Conversation
Looks like the Ubuntu 20.02 & Puppet 5 acceptance failure was networking issues boostrapping the beaker nodeset. Will need to be rerun. |
Ubuntu 29 + puppet 5 is expected to fail because puppet does not provide packages fro them :( |
Looks like majority of tests are failing virtualenv with this error:
After much googling at least with Ubuntu 20.04 the online solutions did not work. The only way around it was not trying to install |
@bastelfreak I am not real familiar with how voxpupuli modulesync sets up |
we havn't figured out yet how to exclude sets :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, but will keep it open for a day or two so others can review it as well
@crazymind1337 can you take a look as well? |
@treydock can you rebase against master to get rid of the merge commit? |
@bastelfreak I had done a merge to get in the virtualenv unit tests which needed to be adjusted for this pull request. Looks to have resolved the conflicts. |
Tested on latest ubuntu:20.04 docker container with puppet6. Works for me! |
@treydock You still have to fix the Commit messages. It looks like there is something wrong. |
Nevermind. I will squash it. |
Pull Request (PR) description
Add support for Ubuntu 20.04. Had to force virtualenv to not use
distribute
otherwise produces errors. Also updated virtualenv tests to consistently use Python 3 since first set of tests did this but subsequent tests did not and that broke some OS acceptance tests.This Pull Request (PR) fixes the following issues
Replaces #576