Fix python::virtualenv to allow virtualenv to not require absolute path #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
treydock
changed the title
|
@treydock can you maybe add a test that enforces it's just a string? Otherwise I'm friend this gets changed to Stdlib::Absolutepath soonish again |
|
@bastelfreak Added unit tests for virtualenv. |
bastelfreak
approved these changes
Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
I maintain several modules where I might do something like
virtualenv => 'virtualenv-3'and that works just fine and doesn't require me to know the full path on each OS. Also the default value if undef is justvirtualenvso doesn't make sense to require the non-default values be more restrictive than the default.